[PATCH] D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing

[Digger Lin via Phabricator via llvm-commits]

DiggerLin added inline comments.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:95
+XCOFFObjectFile::getSymbolAuxType(uintptr_t AuxiliaryEntryAddress) {
+  return viewAs<XCOFF::SymbolAuxType>(
+      getWithOffset(AuxiliaryEntryAddress, SymbolAuxTypeOffset));
----------------
SymbolAuxType is only for the 64 bits.
add assert(is64Bit() ) before return ?


================
Comment at: llvm/tools/llvm-readobj/XCOFFDumper.cpp:365
 #endif
       printFileAuxEnt(FileAuxEntPtr);
     }
----------------
as you mention "I think it's the caller's responsibility to make sure they are passing in the right auxiliary type. "

I think we need to check the AuxType == XCOFF::AUX_FILE for 64 bits. if not , print out the raw data as AUX_CSECT did ?



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85774/new/

https://reviews.llvm.org/D85774