[PATCH] D102096: [DAGCombiner] Fix DAG combine store elimination, different address space.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 12 05:27:45 PDT 2021


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:17915
   // is dead/noop.
   // TODO: Can relax for unordered atomics (see D66309)
   if (LoadSDNode *Ld = dyn_cast<LoadSDNode>(Value)) {
----------------
RKSimon wrote:
> Add an additional TODO comment about adding a isNoopAddrSpaceCast check
No, do not add this todo. It does not make any sense. There is no addrspacecasting going on in this context


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102096/new/

https://reviews.llvm.org/D102096



More information about the llvm-commits mailing list