[PATCH] D102096: [DAGCombiner] Fix DAG combine store elimination, different address space.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.

LGTM with a few minors (update the patch just before commit - no need to get the TODO comments reviewed again)



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:17915
   // is dead/noop.
   // TODO: Can relax for unordered atomics (see D66309)
   if (LoadSDNode *Ld = dyn_cast<LoadSDNode>(Value)) {
----------------
Add an additional TODO comment about adding a isNoopAddrSpaceCast check


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:17928
 
   // TODO: Can relax for unordered atomics (see D66309)
   if (StoreSDNode *ST1 = dyn_cast<StoreSDNode>(Chain)) {
----------------
Add an additional TODO comment 


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:17940
 
       if (OptLevel != CodeGenOpt::None && ST1->hasOneUse() &&
           !ST1->getBasePtr().isUndef() &&
----------------
Add a TODO comment 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102096/new/

https://reviews.llvm.org/D102096