[PATCH] D102166: AMDGPU: Fix SILoadStoreOptimizer for gfx90a

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 10 08:07:30 PDT 2021


rampitec added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/promote-constOffset-to-imm-gfx90a.mir:4
+# GFX9-LABEL: name: diffoporder_add
+# GFX9: %{{[0-9]+}}:vreg_64_align2 = GLOBAL_LOAD_DWORDX2 %{{[0-9]+}}, -2048, 0
+# GFX9: %{{[0-9]+}}:vreg_64_align2 = GLOBAL_LOAD_DWORDX2 %{{[0-9]+}}, 0, 0
----------------
Does it check what you have changed? RC is checked for vdst, and the change is about the base address RC.


================
Comment at: llvm/test/CodeGen/AMDGPU/promote-constOffset-to-imm.ll:114
+
+; GFX90A:    global_load_dwordx2 v[{{[0-9]+:[0-9]+}}], v[{{[0-9]+:[0-9]+}}], off offset:-4096
+; GFX90A:    global_load_dwordx2 v[{{[0-9]+:[0-9]+}}], v[{{[0-9]+:[0-9]+}}], off offset:-2048
----------------
It seems the same as GFX9 checks, just needs -DAG?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102166/new/

https://reviews.llvm.org/D102166



More information about the llvm-commits mailing list