[PATCH] D102166: AMDGPU: Fix SILoadStoreOptimizer for gfx90a

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 10 15:06:38 PDT 2021


arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/promote-constOffset-to-imm.ll:114
+
+; GFX90A:    global_load_dwordx2 v[{{[0-9]+:[0-9]+}}], v[{{[0-9]+:[0-9]+}}], off offset:-4096
+; GFX90A:    global_load_dwordx2 v[{{[0-9]+:[0-9]+}}], v[{{[0-9]+:[0-9]+}}], off offset:-2048
----------------
rampitec wrote:
> It seems the same as GFX9 checks, just needs -DAG?
Yes and no. These have identical interleaved sections. These tests aren't great since they should really be testing the sets with the same base pointers, but those checks are missing. -DAG would work if the base pointers were checked


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102166/new/

https://reviews.llvm.org/D102166



More information about the llvm-commits mailing list