[PATCH] D101455: [ELF] Implement RISCV::getImplicitAddend()

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Looks reasonable to me. The base patches need a bit more work, though.

I think the overall complexity (generic code plus target-specific code) supporting REL isn't that high.
This supports both (1) -z rel and (2) check our dynamic relocation addends are correct.



================
Comment at: lld/ELF/Arch/RISCV.cpp:155
+  case R_RISCV_JUMP_SLOT:
+    return 0; // The stored value at this location is not the addend.
+  }
----------------
The value at this location is not used.

ld.so implementations don't use addend for JUMP_SLOT/GLOB_DAT. NONE is just ignored.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101455/new/

https://reviews.llvm.org/D101455