[PATCH] D100490: [ELF] Refactor DynamicReloc to fix incorrect relocation addends

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 28 07:04:37 PDT 2021


arichardson marked an inline comment as done.
arichardson added inline comments.


================
Comment at: lld/ELF/InputSection.cpp:1021
 
+    if (rel.expr == R_ADDEND) {
+      target->relocate(bufLoc, rel, rel.addend);
----------------
This is needed now to avoid UB caused by`*rel.sym` if rel.sym is NULL.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100490/new/

https://reviews.llvm.org/D100490



More information about the llvm-commits mailing list