[PATCH] D101068: [ELF] Emit diagnostic for invalid size directive

Mon Apr 26 08:00:14 PDT 2021

bcain added a comment.

In D101068#2714208 <https://reviews.llvm.org/D101068#2714208>, @MaskRay wrote:

> Is it overkill to add a spell corrector? .size is usually generated by the compiler, so this can only be useful for hand-written assembly. Though I wonder how many times this can be useful.

For whatever reason, many hexagon developers frequently use the .size directive to set the function size correctly when hand-writing assembly.  There may be / may have been some developer scripts that expected/relied on this being set.

This particular patch is inspired by developer bug reports - including one that had a .size referencing a label incorrectly - with a single-character error: differing only in case.

If you think the "did you mean..." is overkill, I am happy to remove it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101068/new/

https://reviews.llvm.org/D101068