[PATCH] D100717: [InstCombine] Transform memcpy to ptr load/stores if TBAA says so

Tue Apr 27 01:03:31 PDT 2021

lebedev.ri added a comment.

In D100717#2718740 <https://reviews.llvm.org/D100717#2718740>, @jeroen.dobbelaere wrote:

> In D100717#2718366 <https://reviews.llvm.org/D100717#2718366>, @aqjune wrote:
>
>> In D100717#2716900 <https://reviews.llvm.org/D100717#2716900>, @fhahn wrote:
>>
>>> But my suggestion/question is the other way around: check if a pointer is used to load a pointer instead of checking if `tbaa` claims it should be treated as pointer.
>>
>> Well, actually this sounds like a great idea... Let me check whether it works.
>
> At least one case where this won't work is when the `llvm.memcpy` is expanded first, before the containing function is inlined in another one, where the access types are exposed.

That's precisely my point about that being a flipped-direction of D88789 <https://reviews.llvm.org/D88789>.
Nowadays, it should be a obviously not a good idea.
I don't believe i will be okay with a patch doing that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100717/new/

https://reviews.llvm.org/D100717