[PATCH] D101068: [ELF] Emit diagnostic for invalid size directive

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 26 20:24:06 PDT 2021


MaskRay added a comment.

Yeah, I kinda feel like we are not making good use of the 50 lines of code. .size is too minor a feature that I'd waste 50 lines, adding `MCAssembler &Asm,` in various places to make this work.
To make good use of the 50 lines, this should be something generic (think as a utility similar to `evaluateAsRelocatable`), so that every other directive which has similar usage to .size can benefit from this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101068/new/

https://reviews.llvm.org/D101068



More information about the llvm-commits mailing list