[PATCH] D101027: [CSKY 7/n] Add more basic instructions including some privilege instructions

Zixuan Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 22 23:27:42 PDT 2021


zixuan-wu added a comment.

In D101027#2708534 <https://reviews.llvm.org/D101027#2708534>, @rengolin wrote:

> The old 7 is now 9 and there's no 8? This is confusing.
>
> Given that we have already merged the initial part, I think you can stop numbering the patches unless they're meant as a set, which then you start from one again (ex: 1/3, 2/3, 3/3).
>
> Normally we would have gone all the way down small programs being generated (including ALU), but we started wrong, so let's not make it more confusing. :)
>
> However, it's still important to know which patch depends on which, so make sure to still mark the parent/child dependencies correctly.

Because there is other patch between 7 and 9, which I will make a revision later.  As I plan to delay the patch of number 9 (codegen) until all basic instructions have been upstreamed, I renumber the 9 to next and next as need. Or we just abandon the prefix pattern `[CSKY 7/n]`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101027/new/

https://reviews.llvm.org/D101027



More information about the llvm-commits mailing list