[PATCH] D101027: [CSKY 7/n] Add more basic instructions including some privilege instructions

Min-Yih Hsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 22 10:05:07 PDT 2021


myhsu added inline comments.


================
Comment at: llvm/lib/Target/CSKY/CSKYInstrInfo.td:464
+  def BSETI32 : I_5_XZ<0xA, 0x2, "bseti32",
+  (outs GPR:$rz), (ins GPR:$rx, uimm5:$imm5), []>;
+
----------------
from 426 to this line there seems to be leading whitespaces before each line, can you remove it?


================
Comment at: llvm/lib/Target/CSKY/CSKYInstrInfo.td:477
+
+  def RFI32 : I_5_XZ_PRIVI<0x11, 0x1, "rfi32">;
+
----------------
can you remove the leading whitespaces?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101027/new/

https://reviews.llvm.org/D101027



More information about the llvm-commits mailing list