[PATCH] D101027: [CSKY 7/n] Add more basic instructions including some privilege instructions

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

In D101027#2711116 <https://reviews.llvm.org/D101027#2711116>, @zixuan-wu wrote:

> Because there is other patch between 7 and 9, which I will make a revision later.

I thought as much, but it's confusing because it's not public. :)

> As I plan to delay the patch of number 9 (codegen) until all basic instructions have been upstreamed, I renumber the 9 to next and next as need.

The number series is an information for the reviewers to know there are more dependencies up front, on a closed series.

So, either you upload all patches at once and number them from 1 to N, or you don't number and just link them via parent/child.

Also, avoid posting patches that can't be merged on the current tree (like one after a private one). It makes review a lot harder because we don't know your internal order, only what's public.

> Or we just abandon the prefix pattern like `[CSKY 7/n]`?

I think we better drop the numbers for now. Just make sure you have the right parent/child relationship and post patches that can be merged directly (with all the clear public dependencies merged before).

Thanks!
--renato


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101027/new/

https://reviews.llvm.org/D101027