[PATCH] D100854: [TableGen] Change assertion information from a tuple to a struct [NFC]

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 22 10:14:56 PDT 2021


craig.topper added inline comments.


================
Comment at: llvm/lib/TableGen/TGParser.cpp:437
+        Dest->push_back(std::make_unique<Record::AssertionInfo>(E.Assertion->Loc,
+                                                                std::move(Condition),
+                                                                std::move(Message)));
----------------
Why std::move on the Condition and Message pointers? I don't think that's doing anything.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100854/new/

https://reviews.llvm.org/D100854



More information about the llvm-commits mailing list