[PATCH] D100854: [TableGen] Change assertion information from a tuple to a struct [NFC]

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 22 10:06:20 PDT 2021


dblaikie added a comment.

In D100854#2709200 <https://reviews.llvm.org/D100854#2709200>, @Paul-C-Anagnostopoulos wrote:

> I have incorporated the lint changes and David's suggestions.
>
> @dblaikie: Could you explain more about what I should say about the AssertionInfo constructor? I don't understand what you meant about the constructor and make_unique().

Oh, something like // user-defined dtor to support std::make_unique, can be removed in C++20 where braced init is supported


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100854/new/

https://reviews.llvm.org/D100854



More information about the llvm-commits mailing list