[PATCH] D100854: [TableGen] Change assertion information from a tuple to a struct [NFC]

[Paul C. Anagnostopoulos via Phabricator via llvm-commits]

Paul-C-Anagnostopoulos added inline comments.


================
Comment at: llvm/lib/TableGen/TGParser.cpp:437
+        Dest->push_back(std::make_unique<Record::AssertionInfo>(E.Assertion->Loc,
+                                                                std::move(Condition),
+                                                                std::move(Message)));
----------------
craig.topper wrote:
> Why std::move on the Condition and Message pointers? I don't think that's doing anything.
Nope, it isn't. But it was when I slipped back into deleting-pointer-deletes-referent thinking mode. Another result of 20 years of programming in memory-managed languages.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100854/new/

https://reviews.llvm.org/D100854