[PATCH] D101027: [CSKY 7/n] Add more basic instructions including some privilege instructions

Min-Yih Hsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 22 09:42:17 PDT 2021


myhsu added a comment.

In D101027#2708534 <https://reviews.llvm.org/D101027#2708534>, @rengolin wrote:

> The old 7 is now 9 and there's no 8? This is confusing.

+1

> Given that we have already merged the initial part, I think you can stop numbering the patches unless they're meant as a set, which then you start from one again (ex: 1/3, 2/3, 3/3).
>
> Normally we would have gone all the way down small programs being generated (including ALU), but we started wrong, so let's not make it more confusing. :)

Agree. the now 9-th patch, which contains more fundamental instructions, might be better to come before this one

> However, it's still important to know which patch depends on which, so make sure to still mark the parent/child dependencies correctly.

+1 I was not able to find this patch in the review stack either


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101027/new/

https://reviews.llvm.org/D101027



More information about the llvm-commits mailing list