[PATCH] D100648: [flang][f18] Add an additional check for semantic errors

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 19 08:59:19 PDT 2021


awarzynski added a comment.

In D100648#2698677 <https://reviews.llvm.org/D100648#2698677>, @klausler wrote:

> It's okay to have the derived type table builder catch errors so long as it's always run.

Currently it's only run for `-fdebug-dump-symbols`. Should it be always run instead?

> In this case, though, the errors are bogus, so it's kind of a moot point.

Do you recommend that we don't check these errors and that this change is not merged?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100648/new/

https://reviews.llvm.org/D100648



More information about the llvm-commits mailing list