[PATCH] D100648: [flang][f18] Add an additional check for semantic errors

Mon Apr 19 10:33:56 PDT 2021

klausler added a comment.

In D100648#2698786 <https://reviews.llvm.org/D100648#2698786>, @awarzynski wrote:

> In D100648#2698677 <https://reviews.llvm.org/D100648#2698677>, @klausler wrote:
>
>> It's okay to have the derived type table builder catch errors so long as it's always run.
>
> Currently it's only run for `-fdebug-dump-symbols`. Should it be always run instead?

That subroutine will have to always run when code is going to be lowered.  So it will soon always have to run unless a syntax-only option is in effect.

>> In this case, though, the errors are bogus, so it's kind of a moot point.
>
> Do you recommend that we don't check these errors and that this change is not merged?

These checks are valid, but they obviously can't be applied until you fix the bogus errors.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100648/new/

https://reviews.llvm.org/D100648