[PATCH] D100648: [flang][f18] Add an additional check for semantic errors

Mon Apr 19 08:15:10 PDT 2021

klausler added a comment.

In D100648#2698449 <https://reviews.llvm.org/D100648#2698449>, @PeteSteinfeld wrote:

> All builds, tests, and looks good.
>
> But I'm concerned that we may be sweeping problems under the rug with this change.  @klausler, shouldn't all semantic errors be caught by the end of execution of `semantics.perform()`?  If so, we should track down all of the errors revealed by data05.f90, offsets01.f90, offsets02.f90, and typeinfo01.f90 and make sure that they're handled in `semantics.perform()` and write tests for them.

All user-caused errors must be caught by the end of semantics (specifically, before lowering) and all messages created by then.  It's okay to have the derived type table builder catch errors so long as it's always run.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100648/new/

https://reviews.llvm.org/D100648