[PATCH] D100648: [flang][f18] Add an additional check for semantic errors

Pete Steinfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 19 06:43:05 PDT 2021


PeteSteinfeld accepted this revision.
PeteSteinfeld added a comment.
This revision is now accepted and ready to land.

All builds, tests, and looks good.

But I'm concerned that we may be sweeping problems under the rug with this change.  @klausler, shouldn't all semantic errors be caught by the end of execution of `semantics.perform()`?  If so, we should track down all of the errors revealed by data05.f90, offsets01.f90, offsets02.f90, and typeinfo01.f90 and make sure that they're handled in `semantics.perform()` and write tests for them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100648/new/

https://reviews.llvm.org/D100648



More information about the llvm-commits mailing list