[PATCH] D100618: [RISCV] Pad v4i1/v2i1/v1i1 stores with 0s to make a full byte.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 15 21:20:20 PDT 2021


craig.topper created this revision.
craig.topper added reviewers: frasercrmck, HsiangKai, khchen, arcbbb, evandro, rogfer01.
Herald added subscribers: StephenFan, vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, hiraditya.
craig.topper requested review of this revision.
Herald added a subscriber: MaskRay.
Herald added a project: LLVM.

As noted in the FIXME there's a sort of agreement that the any
extra bits stored will be 0.

The generated code is pretty terrible. I was really hoping we
could use a tail undisturbed trick, but tail undisturbed no
longer applies to masked destinations in the current draft
spec.

Fingers crossed that it isn't common to do this. I doubt IR
from clang or the vectorizer would ever create this kind of store.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D100618

Files:
  llvm/lib/Target/RISCV/RISCVISelLowering.cpp
  llvm/test/CodeGen/RISCV/rvv/fixed-vectors-extload-truncstore.ll
  llvm/test/CodeGen/RISCV/rvv/fixed-vectors-extract-subvector.ll
  llvm/test/CodeGen/RISCV/rvv/fixed-vectors-fp-setcc.ll
  llvm/test/CodeGen/RISCV/rvv/fixed-vectors-mask-load-store.ll
  llvm/test/CodeGen/RISCV/rvv/fixed-vectors-mask-splat.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100618.337978.patch
Type: text/x-patch
Size: 33126 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210416/31fbf570/attachment.bin>


More information about the llvm-commits mailing list