[PATCH] D100614: [Coroutine] Collect CoroBegin if all of terminators are dominated by one coro.destroy
Xun Li via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Apr 18 13:38:04 PDT 2021
lxfind added a comment.
Does it require that all terminators to be dominated by the same coro.destroy?
Reading the comments in the original code, I think the condition is that for each terminator it's dominated by a coro.destroy, but it doesn't require all terminators to be dominated by the same coro.destroy.
The original code does seem to be buggy, but the fix may not be correct. Perhaps in the next statement, the check on hasEscapePath and ReferencedCoroBegins.count is problematic?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100614/new/
https://reviews.llvm.org/D100614
More information about the llvm-commits
mailing list