[PATCH] D98511: [llvm-objcopy][NFC] Move ownership keeping code into restoreStatOnFile()

[Manoj Gupta via Phabricator via llvm-commits]

manojgupta added a comment.

@avl Did you test this change? It has broken setuid permission preservation with sudo.

Repro case:

$ chmod +s main main
$ -rwsr-sr-x 1 manojgupta primarygroup 5936 Apr 11 17:46 main
$ sudo bin/llvm-strip main
$ ls -l main
-rwxr-xr-x 1 manojgupta primarygroup 5936 Apr 11 17:46 main

Note that setuid bit was removed.

This is causing breakage in chrome os builds :
https://bugs.chromium.org/p/chromium/issues/detail?id=1197970

Please fix or revert.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98511/new/

https://reviews.llvm.org/D98511