[PATCH] D98240: [VectorCombine] Simplify to scalar store if only one element updated

[Qiu Chaofan via Phabricator via llvm-commits]

qiucf added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VectorCombine.cpp:807
+    replaceValue(I, *NSI);
+    I.eraseFromParent();
+    return true;
----------------
fhahn wrote:
> Is there a reason to remove the instruction here? I don't think the other functions do so, so it might be better to keep things consistent (or change it for other patterns as well)
I think that's because we're operating on a `store`, which will not be erased automatically for empty use.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98240/new/

https://reviews.llvm.org/D98240