[PATCH] D100034: [Windows] Remove global OF_None flag for Windows in ToolOutputFiles
Abhina Sree via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 7 11:10:17 PDT 2021
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5c8462b5daa2: [Windows] Remove global OF_None flag for Windows in ToolOutputFiles (authored by abhina.sreeskantharajan).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100034/new/
https://reviews.llvm.org/D100034
Files:
llvm/lib/Support/ToolOutputFile.cpp
Index: llvm/lib/Support/ToolOutputFile.cpp
===================================================================
--- llvm/lib/Support/ToolOutputFile.cpp
+++ llvm/lib/Support/ToolOutputFile.cpp
@@ -46,12 +46,7 @@
EC = std::error_code();
return;
}
-
- // On Windows, we set the OF_None flag even for text files to avoid
- // CRLF translation.
- OSHolder.emplace(
- Filename, EC,
- llvm::Triple(LLVM_HOST_TRIPLE).isOSWindows() ? sys::fs::OF_None : Flags);
+ OSHolder.emplace(Filename, EC, Flags);
OS = OSHolder.getPointer();
// If open fails, no cleanup is needed.
if (EC)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100034.335874.patch
Type: text/x-patch
Size: 604 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210407/fa46ca5d/attachment.bin>
More information about the llvm-commits
mailing list