[PATCH] D100034: [Windows] Remove global OF_None flag for Windows in ToolOutputFiles

[Abhina Sree via Phabricator via llvm-commits]

abhina.sreeskantharajan added a comment.

In D100034#2674519 <https://reviews.llvm.org/D100034#2674519>, @rnk wrote:

> This change isn't NFC, there are many places we use OF_TextWithCRLF with ToolOutputFile:
> https://github.com/llvm/llvm-project/blob/main/llvm/tools/llvm-dis/llvm-dis.cpp#L206
>
> In any case, this is my preferred future direction, so let's just make the code change and fix any fallout.

So I added this workaround in https://reviews.llvm.org/D97785. All ToolOutputFiles that were marked with OF_Text **after this workaround** are still OF_Text and shouldn't turn on CRLF translation. Therefore I don't think there will be any fallout on Windows. Any ToolOutputFile **prior to this workaround** that was marked as OF_Text was changed to OF_TextWithCRLF like the one in llvm-dis.cpp. My follow-up question is should we change those back to OF_Text or leave them as OF_TextWithCRLF?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100034/new/

https://reviews.llvm.org/D100034