[PATCH] D99692: [globalisel][unittests] Rename setUp() to avoid potential mix up with SetUp() from gtest

Justin Bogner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 31 16:54:12 PDT 2021


bogner accepted this revision.
bogner added a comment.
This revision is now accepted and ready to land.

The title/summary seems a bit confusing. The interesting part of this change is having the set up function return a target machine so it's impossible to miss - IMO renaming it is incidental. This seems reasonable to do, but I think it'd be better titled something along the lines of "Return a target machine from the test setup so that it's structurally required"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99692/new/

https://reviews.llvm.org/D99692



More information about the llvm-commits mailing list