[PATCH] D99692: [globalisel][unittests] Rename setUp() to avoid potential mix up with SetUp() from gtest

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 31 16:59:59 PDT 2021


dsanders added a comment.

In D99692#2662702 <https://reviews.llvm.org/D99692#2662702>, @bogner wrote:

> The title/summary seems a bit confusing. The interesting part of this change is having the set up function return a target machine so it's impossible to miss - IMO renaming it is incidental. This seems reasonable to do, but I think it'd be better titled something along the lines of "Return a target machine from the test setup so that it's structurally required"

Sure I can swap them around. Thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99692/new/

https://reviews.llvm.org/D99692



More information about the llvm-commits mailing list