[PATCH] D69428: [GlobalOpt] Remove valgrind specific hacks (revert r160529)

Tue Mar 30 08:42:47 PDT 2021

tejohnson added a comment.

In D69428#2658027 <https://reviews.llvm.org/D69428#2658027>, @nlopes wrote:

> In D69428#2658010 <https://reviews.llvm.org/D69428#2658010>, @evgeny777 wrote:
>
>> @nlopes
>>
>>> Not sure you are still interested in this patch. If so, I would suggest you get in touch with some Google folks and check with them if their codebase is ready for this patch. They were the only reason for this workaround.
>>
>> Yeah, it would be nice to get rid of this valgrind legacy (btw, there is already D70006 <https://reviews.llvm.org/D70006> which eliminates such kind of unneeded globals for thin LTO). However I don't whom to contact.
>
> @tejohnson @chandlerc @hans should be able to point out someone that can comment on this and/or test if this patch regresses google's leak tests.

Added @chandlerc as reviewer here since he was involved in the original discussion at https://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20120625/145646.html.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69428/new/

https://reviews.llvm.org/D69428