[PATCH] D69428: [GlobalOpt] Remove valgrind specific hacks (revert r160529)

[Eugene Leviant via Phabricator via llvm-commits]

evgeny777 added inline comments.


================
Comment at: test/Transforms/GlobalOpt/2009-11-16-BrokenPerformHeapAllocSRoA.ll:20
   %4 = tail call i8* @malloc(i64 %3)              ; <i8*> [#uses=1]
-; CHECK-NOT: call i8* @malloc(i64
+; CHECK: call i8* @malloc(i64
   %5 = bitcast i8* %4 to %struct.strchartype*     ; <%struct.strchartype*> [#uses=1]
----------------
nlopes wrote:
> is this a regression? The internal `@chartypes` global is never read, so the store can go away (well, the whole function is a nop).
Doubtful. instcombine run after global opt converts the whole function to `ret void`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69428/new/

https://reviews.llvm.org/D69428