[PATCH] D69428: [GlobalOpt] Remove valgrind specific hacks (revert r160529)

[Nuno Lopes via Phabricator via llvm-commits]

nlopes added subscribers: hans, chandlerc.
nlopes added a comment.

In D69428#2658010 <https://reviews.llvm.org/D69428#2658010>, @evgeny777 wrote:

> @nlopes
>
>> Not sure you are still interested in this patch. If so, I would suggest you get in touch with some Google folks and check with them if their codebase is ready for this patch. They were the only reason for this workaround.
>
> Yeah, it would be nice to get rid of this valgrind legacy (btw, there is already D70006 <https://reviews.llvm.org/D70006> which eliminates such kind of unneeded globals for thin LTO). However I don't whom to contact.

@tejohnson @chandlerc @hans should be able to point out someone that can comment on this and/or test if this patch regresses google's leak tests.



================
Comment at: test/Transforms/GlobalOpt/2009-11-16-BrokenPerformHeapAllocSRoA.ll:20
   %4 = tail call i8* @malloc(i64 %3)              ; <i8*> [#uses=1]
-; CHECK-NOT: call i8* @malloc(i64
+; CHECK: call i8* @malloc(i64
   %5 = bitcast i8* %4 to %struct.strchartype*     ; <%struct.strchartype*> [#uses=1]
----------------
is this a regression? The internal `@chartypes` global is never read, so the store can go away (well, the whole function is a nop).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69428/new/

https://reviews.llvm.org/D69428