[PATCH] D99537: [OPENMP51]Initial support for the dispatch directive

[Mike Rice via Phabricator via llvm-commits]

mikerice marked 3 inline comments as done.
mikerice added a comment.

Thanks for the review.



================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:9766-9768
+namespace {
+class DispatchStmtExprChecker
+    : public StmtVisitor<DispatchStmtExprChecker, bool> {
----------------
ABataev wrote:
> Why `Expr->IgnoreParenImpCasts()` does not work here?
No reason not to use IgnoreParenImpCasts() instead of IgnoreParens() as far as I know.  That should eliminate the need for visiting MaterializeTemporaryExpr.  It unfortunately doesn't skip over CXXBindTemporaryExpr.  Or were you suggesting something else?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99537/new/

https://reviews.llvm.org/D99537