[PATCH] D99537: [OPENMP51]Initial support for the dispatch directive

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: clang/include/clang/AST/StmtOpenMP.h:5150
+///
+class OMPDispatchDirective : public OMPExecutableDirective {
+  friend class ASTStmtReader;
----------------
`final`


================
Comment at: clang/include/clang/AST/StmtOpenMP.h:5201
+  /// Return location of target-call.
+  SourceLocation getTargetCallLoc() { return TargetCallLoc; }
+
----------------
`const`


================
Comment at: clang/lib/Basic/OpenMPKinds.cpp:649-651
+  case OMPD_dispatch:
+    CaptureRegions.push_back(OMPD_dispatch);
+    break;
----------------
Why do you need to push `OMPD_dispatch` here? Maybe `OMPD_unknown` should be enough?


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:9766-9768
+namespace {
+class DispatchStmtExprChecker
+    : public StmtVisitor<DispatchStmtExprChecker, bool> {
----------------
Why `Expr->IgnoreParenImpCasts()` does not work here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99537/new/

https://reviews.llvm.org/D99537