[PATCH] D99537: [OPENMP51]Initial support for the dispatch directive
Alexey Bataev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 30 05:13:49 PDT 2021
ABataev added inline comments.
================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:9766-9768
+namespace {
+class DispatchStmtExprChecker
+ : public StmtVisitor<DispatchStmtExprChecker, bool> {
----------------
mikerice wrote:
> ABataev wrote:
> > Why `Expr->IgnoreParenImpCasts()` does not work here?
> No reason not to use IgnoreParenImpCasts() instead of IgnoreParens() as far as I know. That should eliminate the need for visiting MaterializeTemporaryExpr. It unfortunately doesn't skip over CXXBindTemporaryExpr. Or were you suggesting something else?
Then just extend `IgnoreParenImpCasts` to support `MaterializeTemporaryExpr` and control it by the parameter.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99537/new/
https://reviews.llvm.org/D99537
More information about the llvm-commits
mailing list