[PATCH] D97964: [flang][OpenMP] Add semantic check for occurrence of multiple list items in aligned clause for simd directive

[Valentin Clement via Phabricator via llvm-commits]

clementval accepted this revision.
clementval added a comment.

LGTM. Please address small comments.



================
Comment at: flang/lib/Semantics/check-directive-structure.h:208
 
+  auto FindClauses(C type) {
+    auto it{GetContext().clauseInfo.equal_range(type)};
----------------
kiranchandramohan wrote:
> Nit: Naming the type here is probably better. Is there an issue?
+1 to @kiranchandramohan comment. 


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:620
+        if (alignedVars.count(*(var.symbol)) == 1) {
+          context_.Say(
+              itr->second->source,
----------------
Please fix the clang-format warning. 


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:629
+    }
+
   } // SIMD
----------------
Remove blank line. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97964/new/

https://reviews.llvm.org/D97964