[PATCH] D97964: [flang][OpenMP] Add semantic check for occurrence of multiple list items in aligned clause for simd directive

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.

LGTM. Please address all lint/clang-format errors. Please wait for @tskeith or @clementval to approve.

Thanks for your work here. Hope you can take this forward in the flow.



================
Comment at: flang/lib/Semantics/check-directive-structure.h:208
 
+  auto FindClauses(C type) {
+    auto it{GetContext().clauseInfo.equal_range(type)};
----------------
Nit: Naming the type here is probably better. Is there an issue?


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:13
+#include "flang/Semantics/symbol.h"
 #include <algorithm>
 
----------------
Nit: Please fix the ordering warning above.


================
Comment at: flang/test/Semantics/omp-simd-aligned.f90:7
+
+program omp_simd
+  integer i, j, k
----------------
Nit: can you add a test with one more variable?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97964/new/

https://reviews.llvm.org/D97964