[PATCH] D98033: [AArch64][SVEIntrinsicOpts] Factor out redundant SVE mul/fmul intrinsics

Joe Ellis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 8 06:53:48 PST 2021


joechrisellis updated this revision to Diff 328999.
joechrisellis marked 5 inline comments as done.
joechrisellis added a comment.

Address review comments.

- @peterwaller-arm:
  - more descriptive variable names.
  - use swap idiom to reduce code duplication.
  - move comments into body of if-statements.
- @david-arm:
  - more descriptive variable names.
  - use existing match functions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98033/new/

https://reviews.llvm.org/D98033

Files:
  llvm/lib/Target/AArch64/SVEIntrinsicOpts.cpp
  llvm/test/CodeGen/AArch64/sve-fmul-idempotency.ll
  llvm/test/CodeGen/AArch64/sve-mul-idempotency.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98033.328999.patch
Type: text/x-patch
Size: 19159 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210308/af924f34/attachment.bin>


More information about the llvm-commits mailing list