[PATCH] D98083: [NFC][AMDGPU] Improve documentation of AMDGPU handling of volatile

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 8 05:01:13 PST 2021


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIMemoryLegalizer.cpp:1704
+
+    // FIXME: Currently LLVM IR marks all atomic operations as volatile. So it
+    // is not possible to tell in LLVM IR if it is a non-volatile atomic, or a
----------------
"LLVM IR marks all atomic operations as volatile": no it doesn't. There are plenty of examples in the lit test suite of load atomic / store atomic / atomicrmw both with and without the volatile keyword.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98083/new/

https://reviews.llvm.org/D98083



More information about the llvm-commits mailing list