[PATCH] D97791: [GlobalISel] Handle non-multiples of the base type in narrowScalarInsert

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 2 12:28:50 PST 2021


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:4719
   Register DstReg = MI.getOperand(0).getReg();
-  if(MRI.getType(DstReg).isVector())
-    MIRBuilder.buildBuildVector(DstReg, DstRegs);
----------------
Does this just break vectors? Part of of the problem is deciding what these even mean for vectors. Does anything break if you just give up on them?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97791/new/

https://reviews.llvm.org/D97791



More information about the llvm-commits mailing list