[PATCH] D97791: [GlobalISel] Handle non-multiples of the base type in narrowScalarInsert

Justin Bogner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 2 11:56:54 PST 2021


bogner added a comment.

In D97791#2598137 <https://reviews.llvm.org/D97791#2598137>, @arsenm wrote:

> I've been thinking we should just stop using G_INSERT/G_EXTRACT for generic legalization. They're weak abstractions over INSERT_SUBREG/EXTRACT_SUBREG, and they probably shouldn't form with illegal types/offsets.

That's probably a reasonable direction but it'll take some doing given that `extractParts` and `insertParts` are pretty prevalent in `LegalizerHelper` today. We need to do something about this if we want any of the other `narrowScalar` code to do the right thing for these kinds of types.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97791/new/

https://reviews.llvm.org/D97791



More information about the llvm-commits mailing list