[PATCH] D97791: [GlobalISel] Handle non-multiples of the base type in narrowScalarInsert

[Justin Bogner via Phabricator via llvm-commits]

bogner marked an inline comment as done.
bogner added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:4719
   Register DstReg = MI.getOperand(0).getReg();
-  if(MRI.getType(DstReg).isVector())
-    MIRBuilder.buildBuildVector(DstReg, DstRegs);
----------------
arsenm wrote:
> Does this just break vectors? Part of of the problem is deciding what these even mean for vectors. Does anything break if you just give up on them?
This is `narrowScalarInsert`, you can't get here with a vector. This handling was added as part of a change that updated a number of `buildMerge` callers and clearly didn't take the context into account.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97791/new/

https://reviews.llvm.org/D97791