[PATCH] D97274: [RISCV] replace unuseful emergency spill slot test with a mir test

Roger Ferrer Ibanez via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 1 02:51:59 PST 2021


rogfer01 added a comment.

> Yes, I referenced this out-of-reach-emergency-slot.mir test. But with a stack object that has a out-of-range size. And I think my use-emergency-spill-slot.mir test and out-of-reach-emergency-slot.mir test are a little repeated. So should I keep my use-emergency-spill-slot.mir test or delete it?

Oh sorry I failed to notice you also adjusted `maxAlignment` to something sensible. Both look very similar but we could argue they are testing different things, so I think this can be useful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97274/new/

https://reviews.llvm.org/D97274



More information about the llvm-commits mailing list