[PATCH] D97403: updated character tests to gtest

Asher Mancinelli via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 25 17:03:22 PST 2021


ashermancinelli added a comment.

In D97403#2588156 <https://reviews.llvm.org/D97403#2588156>, @awarzynski wrote:

> I am also thinking that since procedures from character.cpp don't crash (at least the ones that you test), we don't really need CatchCrash just yet (though it would be great to see it being tested). Perhaps the test fixture could be simplified?

Sure - it seems the existing method of crash recovery (exceptions) is the only way to go here since crash `std::abort`s, so we'll have to redo this part anyways.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97403/new/

https://reviews.llvm.org/D97403



More information about the llvm-commits mailing list