[PATCH] D97403: updated character tests to gtest
Asher Mancinelli via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 25 14:58:30 PST 2021
ashermancinelli added inline comments.
================
Comment at: flang/unittests/RuntimeGTest/CharacterTest.cpp:47
+ void DoCharacterComparison() {
+ int cmp{RTNAME(CharacterCompareScalar1)(x, y, xBytes, yBytes)};
+ char buf[2][8];
----------------
awarzynski wrote:
> [nice-to-have] `CharacterCompareScalar2`, `CharacterCompareScalar3`, `CharacterCompareScalar4` :)
I don't think this would be too hard with some template shenanigans... I'll add it in the next patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97403/new/
https://reviews.llvm.org/D97403
More information about the llvm-commits
mailing list