[PATCH] D97403: updated character tests to gtest

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 26 05:49:23 PST 2021


awarzynski added a comment.

In D97403#2589137 <https://reviews.llvm.org/D97403#2589137>, @ashermancinelli wrote:

> Sure - it seems the existing method of crash recovery (exceptions) is the only way to go here since crash `std::abort`s, so we'll have to redo this part anyways.

Wouldn't death tests <https://github.com/google/googletest/blob/v1.8.x/googletest/docs/advanced.md#death-tests> work here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97403/new/

https://reviews.llvm.org/D97403



More information about the llvm-commits mailing list