[PATCH] D97268: [X86] Use correct padding when in 16-bit mode

Bill Wendling via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 25 15:37:04 PST 2021


void added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:1079
     return 1;
+  if (STI.getFeatureBits()[X86::Mode16Bit])
+    return 4;
----------------
craig.topper wrote:
> Should this just be above the NOPL check if we're going to AND NOPL with !STI.hasFeature(X86::Mode16Bit).
> 
> Should we consistently use hasFeature in this function instead of mixing with getFeatureBits()?
I was told to place this here and not at the start.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97268/new/

https://reviews.llvm.org/D97268



More information about the llvm-commits mailing list