[PATCH] D97268: [X86] Use correct padding when in 16-bit mode

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:1079
     return 1;
+  if (STI.getFeatureBits()[X86::Mode16Bit])
+    return 4;
----------------
void wrote:
> craig.topper wrote:
> > Should this just be above the NOPL check if we're going to AND NOPL with !STI.hasFeature(X86::Mode16Bit).
> > 
> > Should we consistently use hasFeature in this function instead of mixing with getFeatureBits()?
> I was told to place this here and not at the start.
Sorry. I realize that, but that request from James doesn't make sense to me unless James thought the 16-bit NOPs required NOPL. Which they don't. @jyknight can you confirm why you asked for that change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97268/new/

https://reviews.llvm.org/D97268