[PATCH] D97427: [AMDGPU] Do not annotate an else branch if there is a kill

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 25 05:36:05 PST 2021


arsenm added a comment.

In D97427#2587455 <https://reviews.llvm.org/D97427#2587455>, @critson wrote:

> Thank you Piotr and Matt for your comments.
>
> Since I don't really like kills being terminators either, I am going to investigate changing that before pushing this further.

No, no. The exact opposite. My problem is the IR kill intrinsic is not a terminator. In the MIR exec modifications should be terminators as that's the only real mechanism for ensuring correct spill placement around them


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97427/new/

https://reviews.llvm.org/D97427



More information about the llvm-commits mailing list