[PATCH] D97427: [AMDGPU] Do not annotate an else branch if there is a kill

[Carl Ritson via Phabricator via llvm-commits]

critson added a comment.

In D97427#2587457 <https://reviews.llvm.org/D97427#2587457>, @arsenm wrote:

> In D97427#2587455 <https://reviews.llvm.org/D97427#2587455>, @critson wrote:
>
>> Since I don't really like kills being terminators either, I am going to investigate changing that before pushing this further.
>
> No, no. The exact opposite. My problem is the IR kill intrinsic is not a terminator. In the MIR exec modifications should be terminators as that's the only real mechanism for ensuring correct spill placement around them

Ah sorry, I did indeed misread your "isn't" as "is".
Can intrinsics even be terminators?
Or are you suggesting that we should split the block at the kill in the IR level very early in the backend?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97427/new/

https://reviews.llvm.org/D97427